Skip to content

Commit

Permalink
Comments from PR.
Browse files Browse the repository at this point in the history
  • Loading branch information
edgonmsft authored May 25, 2022
1 parent 63a5ed2 commit b304f90
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"@types/js-yaml": "^4.0.5",
"@types/mocha": "^9.1.0",
"@types/node": "^16.11.7",
"@types/ncp": "^2.0.5",
"@types/pull-stream": "^3.6.2",
"@types/semver": "^7.3.9",
"@types/shell-quote": "^1.7.1",
Expand All @@ -65,7 +66,6 @@
"vinyl-fs": "^3.0.3"
},
"dependencies": {
"@types/ncp": "^2.0.5",
"ncp": "^2.0.0",
"follow-redirects": "^1.14.8",
"js-yaml": "^4.1.0",
Expand Down
2 changes: 1 addition & 1 deletion src/spec-common/injectHeadless.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export type DevContainerConfigCommand = 'initializeCommand' | 'onCreateCommand'

const defaultWaitFor: DevContainerConfigCommand = 'updateContentCommand';

export interface DevContainerFeature{
export interface DevContainerFeature {
id: string;
options: boolean | string | Record<string, boolean | string | undefined>;
}
Expand Down
2 changes: 1 addition & 1 deletion src/spec-configuration/configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export interface HostRequirements {
storage?: string;
}

export interface DevContainerFeature{
export interface DevContainerFeature {
id: string;
options: boolean | string | Record<string, boolean | string | undefined>;
}
Expand Down
4 changes: 1 addition & 3 deletions src/spec-configuration/containerFeaturesConfiguration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@

import * as jsonc from 'jsonc-parser';
import * as path from 'path';
//import * as semver from 'semver';
import * as URL from 'url';
import * as tar from 'tar';
import { DevContainerConfig } from './configuration';
import { mkdirpLocal, readLocalFile, rmLocal, writeLocalFile, cpDirectoryLocal } from '../spec-utils/pfs';
import { Log, LogLevel } from '../spec-utils/log';
import { request } from '../spec-utils/httpRequest';
import { DevContainerFeature } from './configuration';
import { existsSync } from 'fs';

const ASSET_NAME = 'devcontainer-features.tgz';
Expand All @@ -25,7 +23,7 @@ export interface Feature {
runApp?: string;
runParams?: string;
infoString?: string;
internalVersion?: string;
internalVersion?: string; // set programmatically
tempLocalPath?: string;
consecutiveId?: string;
install?: Record<string, string>;
Expand Down

0 comments on commit b304f90

Please sign in to comment.