Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --skip-post-attach to skip running the post attach command #174

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Add --skip-post-attach to skip running the post attach command #174

merged 5 commits into from
Sep 15, 2022

Conversation

joshaber
Copy link
Contributor

@joshaber joshaber commented Sep 13, 2022 •
edited
Loading

Teach up and run-user-commands the --skip-post-attach option so that attaching clients can take ownership for running post attach themselves.

@joshaber joshaber marked this pull request as ready for review September 13, 2022 21:09
@joshaber joshaber requested a review from a team as a code owner September 13, 2022 21:09
chrmarti
chrmarti approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

edgonmsft
edgonmsft approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@edgonmsft edgonmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshaber joshaber merged commit 596544a into devcontainers:main Sep 15, 2022
@joshaber joshaber deleted the joshaber/skip-post-attach branch September 15, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgonmsft edgonmsft edgonmsft approved these changes

@chrmarti chrmarti chrmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshaber @chrmarti @edgonmsft