Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates & Features Packaging - Throw warning of a missing JSON file and continue #206

Merged
merged 7 commits into from
Oct 7, 2022

Conversation

samruddhikhandale
Copy link
Member

@samruddhikhandale samruddhikhandale commented Oct 6, 2022

When packaging a collection of templates with templates publish or feature publish cmd , it errors out when a sub-folder does not contain files meant for templates publishing (eg. devcontainer-*.json).

This PR warns about empty directories, but still continue. That would make the user aware of a missing JSON file, but still support the case where this is expected.

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner October 6, 2022 22:08
@joshspicer
Copy link
Member

I feel like we shouldn't need a flag for this, but rather just (1) not allow empty directories or (2) always allow empty directories and automatically ignore.

Perhaps there is an example you have where this indeed the best way to do it?

@chrmarti
Copy link
Contributor

chrmarti commented Oct 7, 2022

I feel like we shouldn't need a flag for this, but rather just (1) not allow empty directories or (2) always allow empty directories and automatically ignore.

Perhaps there is an example you have where this indeed the best way to do it?

Or: Warn about empty directories, but still continue. That would make the user aware of a missing JSON file, but still support the case where this is expected.

@samruddhikhandale
Copy link
Member Author

Or: Warn about empty directories, but still continue. That would make the user aware of a missing JSON file, but still support the case where this is expected.

This makes sense. I'll update the PR.

@samruddhikhandale samruddhikhandale changed the title templates publish cmd - adds --allow-dir-without-template option Templates & Features Packaging - Throw warning of a missing JSON file and continue Oct 7, 2022
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samruddhikhandale samruddhikhandale merged commit 74ec70e into main Oct 7, 2022
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/modify-templates-publish branch October 7, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants