-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates & Features Packaging - Throw warning of a missing JSON file and continue #206
Templates & Features Packaging - Throw warning of a missing JSON file and continue #206
Conversation
I feel like we shouldn't need a flag for this, but rather just (1) not allow empty directories or (2) always allow empty directories and automatically ignore. Perhaps there is an example you have where this indeed the best way to do it? |
Or: Warn about empty directories, but still continue. That would make the user aware of a missing JSON file, but still support the case where this is expected. |
This makes sense. I'll update the PR. |
templates publish
cmd - adds --allow-dir-without-template optionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
When packaging a collection of templates with
templates publish
orfeature publish
cmd , it errors out when a sub-folder does not contain files meant for templates publishing (eg.devcontainer-*.json
).This PR warns about empty directories, but still continue. That would make the user aware of a missing JSON file, but still support the case where this is expected.