Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[features test cmd] Respect image label metadata #288

Merged
merged 6 commits into from
Nov 18, 2022

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Nov 16, 2022

Adds a new flag --skip-image-metadata with a default state of false, reflecting the default behavior of the CLI to apply container image label metadata to the resultant image.

@joshspicer joshspicer requested a review from a team as a code owner November 16, 2022 23:18
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one suggestion.

src/spec-node/featuresCLI/test.ts Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@joshspicer joshspicer dismissed chrmarti’s stale review November 18, 2022 18:23

Addressed comment as requested

@joshspicer joshspicer merged commit 790aa75 into main Nov 18, 2022
@joshspicer joshspicer deleted the joshspicer/features-test/respect-image-metadata branch November 18, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants