Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotfiles functionallity #362

Merged
merged 14 commits into from
Jan 13, 2023
Merged

Add dotfiles functionallity #362

merged 14 commits into from
Jan 13, 2023

Conversation

edgonmsft
Copy link
Contributor

Dotfiles are commonly used as ann extra customization step in devcontainers.

This pr adds 3 more parameters to the up command.
If the values are not present then dotfiles are not executed.

  • dotfiles-repository: Git URL to clone a dotfiles repository from.
  • dotfiles-install-command: Command to install the dotfiles with. If none is given a list of script names (install.sh, install, bootstrap.sh, bootstrap, setup.sh and setup) are checked for in the checked out dotfiles repository and if none is found all top-level dotfiles are symlinked from the container's home folder.
  • dotfiles-target-path: Folder path to clone the dotfiles repository to.

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments!

src/spec-common/dotfiles.ts Show resolved Hide resolved
src/test/cli.up.test.ts Outdated Show resolved Hide resolved
src/test/cli.up.test.ts Show resolved Hide resolved
src/spec-node/devContainersSpecCLI.ts Outdated Show resolved Hide resolved
src/spec-node/devContainersSpecCLI.ts Outdated Show resolved Hide resolved
src/spec-node/devContainersSpecCLI.ts Outdated Show resolved Hide resolved
src/spec-node/devContainersSpecCLI.ts Outdated Show resolved Hide resolved
src/spec-node/devContainers.ts Show resolved Hide resolved
src/spec-node/devContainersSpecCLI.ts Outdated Show resolved Hide resolved
edgonmsft and others added 9 commits January 6, 2023 10:04
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few comments.

src/spec-common/dotfiles.ts Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/dotfiles.ts Outdated Show resolved Hide resolved
src/test/cli.up.test.ts Show resolved Hide resolved
src/spec-common/dotfiles.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants