Automatically set execute bit when running dotfiles install script

[joshspicer]

The bootstrap script will add the execute bit to the 'installCommand' when cloning dotfiles, if it is not already set as executable. This reduces friction in setting up dotfiles.

codspace/test-dotfiles@0a444c1 removes the execute bit from the existing test.

ref: https://github.com/github/codespaces/issues/13870

[chrmarti]

Looks good, added to the previous conversation.

[chrmarti]

More missing quotes, we missed some previously, so probably not critical, but would be good to fix now that we are looking into it.

[joshspicer]

Using both single quotes or double quotes to quote targetPath during the git clone ${targetPath} commands don't work well with shell characters (~) used in the tests. I tried manually making the directory as well, but that doesn't work well either (still unhappy when quoting)

[chrmarti]

Using both single quotes or double quotes to quote targetPath during the git clone ${targetPath} commands don't work well with shell characters (~) used in the tests. I tried manually making the directory as well, but that doesn't work well either (still unhappy when quoting the

Ack, I wasn't aware of that. Let's keep it unquoted then for now, not supporting spaces in the path as we are doing now. (One option to support both might be to check for a leading ~ and put it outside quotes. Or escape spaces with a backslash.)

Maybe still make quoting of installCommand consistent (see my unresolved comments).

[joshspicer]

Yes, made the installCommand quoting changes (didn't realize I hadn't pushed that).