Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Features V2 #6

Merged
merged 33 commits into from
Jun 28, 2022
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
eebacc5
First changes for features
edgonmsft May 9, 2022
e825692
Missing reference.
edgonmsft May 9, 2022
1047e01
Fix test
edgonmsft May 9, 2022
40aa793
Fixes.
edgonmsft May 9, 2022
83afa1b
Run config
edgonmsft May 9, 2022
39cff54
Comment out test
edgonmsft May 9, 2022
12d39a2
Fixes for absolute paths
edgonmsft May 10, 2022
e769e66
Comments on pr.
edgonmsft May 10, 2022
b35174c
Fix for github features.
edgonmsft May 12, 2022
6b59032
Merge remote-tracking branch 'origin/main' into edgon/features-1
edgonmsft May 23, 2022
1e9a5bb
Fixes for locally cacched features.
edgonmsft May 23, 2022
9b98c33
Merge remote-tracking branch 'origin' into edgon/features-1
edgonmsft May 24, 2022
5923ef7
Fix old features.
edgonmsft May 24, 2022
23e87ff
Other fixes.
edgonmsft May 24, 2022
9bce15f
Some comments and formating.
edgonmsft May 24, 2022
91edf38
Test fix
edgonmsft May 24, 2022
971bd56
Fix
edgonmsft May 24, 2022
4e0fc7e
Fix test.
edgonmsft May 24, 2022
4842ec5
Refactor changes and read devcontainer collections.
edgonmsft May 25, 2022
ebbbc4e
Fix test.
edgonmsft May 25, 2022
26f3f35
Fix test.
edgonmsft May 25, 2022
11fb36c
Fix test 3
edgonmsft May 25, 2022
934ae4a
fix test 4
edgonmsft May 25, 2022
63a5ed2
fix test 5
edgonmsft May 25, 2022
b304f90
Comments from PR.
edgonmsft May 25, 2022
5e29707
Fix cleanup
edgonmsft May 25, 2022
ec88721
Remove prefix for environment variables in features v2
edgonmsft Jun 2, 2022
267ef67
support fetching v2 features from github repo (#48)
joshspicer Jun 3, 2022
df7575b
clean up tracing and formatting
joshspicer Jun 8, 2022
1b42a63
Merge remote-tracking branch 'origin/main' into edgon/features-1
edgonmsft Jun 14, 2022
68e68b1
Changes from the last spec proposal changes.
edgonmsft Jun 24, 2022
39a1b22
Comments and fixes from PR.
edgonmsft Jun 27, 2022
e92dd24
Unit test fixes.
edgonmsft Jun 27, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Launch cli - up",
"program": "${workspaceFolder}/src/spec-node/devContainersSpecCLI.ts",
"cwd": "${workspaceFolder}",
"args": [
"up",
"--workspace-folder",
"../devcontainers-features",
"--log-level",
"debug",
],
"console": "integratedTerminal",
}
]
}
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"@types/js-yaml": "^4.0.5",
"@types/mocha": "^9.1.0",
"@types/node": "^16.11.7",
"@types/ncp": "^2.0.5",
"@types/pull-stream": "^3.6.2",
"@types/semver": "^7.3.9",
"@types/shell-quote": "^1.7.1",
Expand All @@ -65,6 +66,7 @@
"vinyl-fs": "^3.0.3"
},
"dependencies": {
"ncp": "^2.0.0",
"follow-redirects": "^1.14.8",
"js-yaml": "^4.1.0",
"jsonc-parser": "^3.0.0",
Expand Down
8 changes: 8 additions & 0 deletions src/spec-configuration/configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ export interface HostRequirements {
storage?: string;
}

export interface DevContainerFeature {
id: string;
options: boolean | string | Record<string, boolean | string | undefined>;
}

export interface DevContainerFromImageConfig {
configFilePath: URI;
image: string;
Expand Down Expand Up @@ -55,6 +60,7 @@ export interface DevContainerFromImageConfig {
updateRemoteUserUID?: boolean;
userEnvProbe?: UserEnvProbe;
features?: Record<string, string | boolean | Record<string, string | boolean>>;
overrideFeatureInstallOrder?: string[];
hostRequirements?: HostRequirements;
}

Expand Down Expand Up @@ -86,6 +92,7 @@ export type DevContainerFromDockerfileConfig = {
updateRemoteUserUID?: boolean;
userEnvProbe?: UserEnvProbe;
features?: Record<string, string | boolean | Record<string, string | boolean>>;
overrideFeatureInstallOrder?: string[];
hostRequirements?: HostRequirements;
} & (
{
Expand Down Expand Up @@ -133,6 +140,7 @@ export interface DevContainerFromDockerComposeConfig {
updateRemoteUserUID?: boolean;
userEnvProbe?: UserEnvProbe;
features?: Record<string, string | boolean | Record<string, string | boolean>>;
overrideFeatureInstallOrder?: string[];
hostRequirements?: HostRequirements;
}

Expand Down
Loading