Fix: propagate --cache-from to buildx build #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
fix/propagate-cache-from
branch
from
13756d8
to
14b394e
Compare
dhhyi
force-pushed
the
fix/propagate-cache-from
branch
from
14b394e
to
cbd9869
Compare
dhhyi
force-pushed
the
fix/propagate-cache-from
branch
from
cbd9869
to
31d5dee
Compare
|
Does this resolve the issue of devcontainer features being rebuilt everytime the devcontainer is used irrespective of prebuilt container? |
chrmarti
requested changes
Mar 14, 2024
dhhyi
force-pushed
the
fix/propagate-cache-from
branch
from
31d5dee
to
5f607e7
Compare
samruddhikhandale
approved these changes
Apr 12, 2024
dhhyi
added a commit
to dhhyi/devcontainer-creator
that referenced
this pull request
Oct 30, 2024
This reverts commit 782503d. fixed with devcontainers/cli#638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to use the new
--cache-tofeature from #570 with a registry cache.If I understand it correctly this only works when using both
--cache-toand--cache-from, but the devcontainers-cli does not send--cache-fromtodocker buildx build.