Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit a Feature pinned version via upgrade cmd #684

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Nov 14, 2023

This change adds new arguments to the upgrade command to facilitate updating a single Feature in a devcontainer.json. After the edit to the devcontainer.json is made, the lockfile is updated according to the requirements (version tags) of each Feature.

upgrade-a-feature.mov

This is useful in dependbot's file_updater step, allowing us to do shell out to the CLI directly for this operation. This is similar to the Swift's file_updater implementation in dependabot core

I've marked this arguments as 'hidden' while I do some initial experimentation. Today the entire lockfile will be regenerated even if --feature is used.

ref: https://github.com/github/codespaces/issues/15791

@joshspicer joshspicer marked this pull request as ready for review November 14, 2023 22:30
@joshspicer joshspicer requested a review from a team as a code owner November 14, 2023 22:30
@joshspicer joshspicer self-assigned this Nov 14, 2023
src/spec-node/upgradeCommand.ts Outdated Show resolved Hide resolved
@joshspicer joshspicer merged commit b33dec4 into main Nov 21, 2023
37 checks passed
@joshspicer joshspicer deleted the joshspicer/update-feature-dependabot branch November 21, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants