Disable cache on feature build when --build-no-cache is passed
#790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjackstewart
changed the title
--build-no-cache is passed
samruddhikhandale
previously approved these changes
Apr 2, 2024
chrmarti
requested changes
Apr 8, 2024
|
@microsoft-github-policy-service agree |
chrmarti
reviewed
Apr 11, 2024
|
@chrmarti or @samruddhikhandale, may you please approve the run of the CI pipeline? 😸 |
robjackstewart
force-pushed
the
control-cache-for-features
branch
from
2462ae7
to
1d9a38c
Compare
The pipeline failed to install dependencies for the windows run. This is unlikely to be related to my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
--no-cachearg to the docker build command that extends the base image with the feature images when--build-no-cacheis passed.Context
The build will always use a cached feature image if it has one. This was making it impossible to replicate a problem in our CI process caused by this issue. Our CI pipeline was failing to install the Azure CLI, but building locally worked fine. The CI pipeline uses GitHub actions, so no cache of the build was available, however, I had cached versions of the image locally and passing the
--build-no-cachecontinued to use the cache. I had to remove all the images viadocker images -q "vsc-$MY_IMAGE*" | xargs docker rmi -forder to get a build representative of my CI environment working locally.Closes #508