-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create features.md #17
Conversation
Yeah I think this would be reasonable to add at this point along with a nav! We can then link to it from the devcontainer.json reference and the main spec. A few thoughts:
|
Thanks for the great feedback, @Chuxel! I believe I addressed the 4 points above:
I also made all the headers in the features and features distribution docs into links for easier sharing and navigation, consistent with the other pages of the site. Please let me know if the changes are in-line with what you were thinking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggested tweaks.
Co-authored-by: Chuck Lantz <clantz@microsoft.com>
Co-authored-by: Chuck Lantz <clantz@microsoft.com>
Co-authored-by: Chuck Lantz <clantz@microsoft.com>
Thanks for the suggestions! Opened devcontainers/spec#69 with the Features wording suggestion you mentioned. I'll merge these changes in as it seems this is a good baseline, and we can continue with other changes folks might have in mind in follow-up PRs. |
Add the content from https://github.com/devcontainers/spec/blob/main/proposals/devcontainer-features.md.
One to-do is to make the headers into links (i.e.
## <a href="#contribution-approaches" name="contribution-approaches" class="anchor"> Contribution approaches </a>
), but that could also be done in a subsequent PR.