Set source property as not required for Mount
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmarti
approved these changes
May 25, 2023
|
@alexander-smolyakov ℹ️ We should merge this PR after changes in devcontainers/cli#537 are released. Thanks! |
|
It looks like the referenced PR was merged and released already? Should this be merged now? |
|
Thanks @avidal, sounds good to me. @samruddhikhandale sound good to you too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
sourceattribute could be omitted for themountcommand. In this case, Docker uses anonymous volumes. We update the devcontainer CLI to support such a case, and we need to update schemas to set thesourceproperty as optional.Changelog:
sourceproperty was removed fromrequiredarray;Related changes:
mountcommand string generation cli#537