Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Metadata Proposal #95

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Image Metadata Proposal #95

merged 4 commits into from
Sep 29, 2022

Conversation

chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Sep 14, 2022 •
edited
Loading

Continuing from #18.

@chrmarti chrmarti requested a review from a team as a code owner September 14, 2022 07:59
@chrmarti chrmarti mentioned this pull request Sep 14, 2022
Closed
Chuxel
Chuxel reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple thoughts/questions

proposals/image-metadata.md Outdated Show resolved Hide resolved
proposals/image-metadata.md Show resolved Hide resolved
@eitsupi eitsupi mentioned this pull request Sep 22, 2022
Closed
samruddhikhandale
samruddhikhandale approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

This was referenced Sep 26, 2022
Merged
Closed
@Chuxel Chuxel self-requested a review September 28, 2022 13:38
@chrmarti chrmarti merged commit b16a6ec into main Sep 29, 2022
@chrmarti chrmarti deleted the chrmarti/imagemetadata branch September 29, 2022 06:10
@chrmarti chrmarti mentioned this pull request Oct 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

@jkeech jkeech jkeech approved these changes

@Chuxel Chuxel Chuxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrmarti @Chuxel @jkeech @joshspicer @samruddhikhandale