-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade 7zip binaries (breaking/major semver) #27
Conversation
… [7-Zip 24.08 (2024-08-11)]
…anges for SZ instead of SZA prefixes added additional documentation to index.d.ts
Tested successfully in electron-builder https://github.com/electron-userland/electron-builder/actions/runs/11018477730 All unit tests passing and the needed changes in upstream app-builder-bin released already (https://github.com/develar/app-builder/releases/tag/v5.0.0-alpha.10) @develar I think this is ready for review 🙃 Let me know if you'd like me to verify anything else! |
e259a09
to
8107d9e
Compare
Thank you and nice to have this awesome PR, but have some problems about it. 1. Different feature supporting between As this repo inactive for so long, I forked this as 7z-bin and did some update, that figured out the So after
Since 2. Ship only
3. Don't use |
Nice to hear your replay! These problems I raised up, are beacause of that, this So I'm curious about the direction of updates, and if this package would going to full focus on serving electron-builder's usage after this breaking change, it would be nice to have a reminder in README. For For windows usage, there are three different executables, Full version of 7-Zip, the |
Ahh that makes sense, alright, then I think we should not proceed with this PR without taking the approach you're suggesting. We need to keep this repo generic for all consumers. Since linux/mac are both now |
TL;DR, The 7-Zip executables was following the naming of That means the new version of The FYI,
|
Upgraded 7-Zip precompiled binaries.
PR version: 24.08
Downloaded from https://www.7-zip.org/download.html, each file is
console version
Added license files and updated README
New binaries are 7zz (mac), 7zz/7zzs (linux), and 7za.exe (win)
Removed previous (vulnerable/deprecated) 7za binaries
Fixes: #21 #22 #26 electron-userland/electron-builder#8485
Changed vars and API to represent
7z
since it's no longer a7za
binary on mac/linuxSZA_PATH
->SZ_PATH
path7za
->path7z
Bumped major semver release to 6.0.0
See README for updated CLI args in changed API of
7zz -h