Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WSL (Windows Subsystem for Linux) support #21

Merged
merged 2 commits into from
Nov 27, 2019

Conversation

SomaticIT
Copy link
Contributor

Hello,

Thank you for making this package!

I tried to use it on WSL (Windows Subsystem for Linux).
WSL is a Linux specially built for running seemlessly.

It could not use wine due to kernel differences but it can call Win32 executables (.exe) directly.

I make an improvement to your lib to detect WSL and call rcedit.exe directly rather than using wine.

Note: I'm also working on a electron-builder PR to add WSL support. This PR will require this change on app-builder

Thanks

pkg/rcedit/rcedit.go Outdated Show resolved Hide resolved
pkg/util/wsl.go Outdated Show resolved Hide resolved
pkg/util/wsl.go Outdated Show resolved Hide resolved
@develar
Copy link
Owner

develar commented Nov 27, 2019

Sorry for delay.

@develar develar merged commit 1897b39 into develar:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants