feat: update rcedit, use rcedit x64 on Windows x64

electron-userland#3889
develar · Jul 7, 2019 · 5e36c67 · 5e36c67
1 parent c8c37f2
commit 5e36c67
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
     "@types/debug": "^4.1.4",
     "@types/is-ci": "^2.0.0",
     "@types/semver": "^6.0.1",
-    "app-builder-bin": "3.1.6",
+    "app-builder-bin": "3.2.0",
     "archiver": "^3.0.0",
     "async-exit-hook": "^2.0.1",
     "bluebird-lst": "^1.0.9",

diff --git a/packages/app-builder-lib/src/winPackager.ts b/packages/app-builder-lib/src/winPackager.ts
@@ -1,5 +1,5 @@
 import BluebirdPromise from "bluebird-lst"
-import { Arch, asArray, InvalidConfigurationError, log, use } from "builder-util"
+import { Arch, asArray, InvalidConfigurationError, log, use, executeAppBuilder } from "builder-util"
 import { parseDn } from "builder-util-runtime"
 import { CopyFileTransformer, FileTransformer, walk } from "builder-util/out/fs"
 import { createHash } from "crypto"
@@ -8,7 +8,7 @@ import isCI from "is-ci"
 import { Lazy } from "lazy-val"
 import * as path from "path"
 import { downloadCertificate } from "./codeSign/codesign"
-import { CertificateFromStoreInfo, CertificateInfo, FileCodeSigningInfo, getCertificateFromStoreInfo, getCertInfo, getSignVendorPath, sign, WindowsSignOptions } from "./codeSign/windowsCodeSign"
+import { CertificateFromStoreInfo, CertificateInfo, FileCodeSigningInfo, getCertificateFromStoreInfo, getCertInfo, sign, WindowsSignOptions } from "./codeSign/windowsCodeSign"
 import { AfterPackContext } from "./configuration"
 import { DIR_TARGET, Platform, Target } from "./core"
 import { RequestedExecutionLevel, WindowsConfiguration } from "./options/winOptions"
@@ -23,7 +23,6 @@ import { BuildCacheManager, digest } from "./util/cacheManager"
 import { isBuildCacheEnabled } from "./util/flags"
 import { time } from "./util/timer"
 import { getWindowsVm, VmManager } from "./vm/vm"
-import { execWine } from "./wine"
 
 export class WinPackager extends PlatformPackager<WindowsConfiguration> {
   readonly cscInfo = new Lazy<FileCodeSigningInfo | CertificateFromStoreInfo | null>(() => {
@@ -318,8 +317,7 @@ export class WinPackager extends PlatformPackager<WindowsConfiguration> {
     const timer = time("wine&sign")
     // rcedit crashed of executed using wine, resourcehacker works
     if (process.platform === "win32" || this.info.framework.name === "electron") {
-      const vendorPath = await getSignVendorPath()
-      await execWine(path.join(vendorPath, "rcedit-ia32.exe"), path.join(vendorPath, "rcedit-x64.exe"), args)
+      await executeAppBuilder(["rcedit", "--args", JSON.stringify(args)])
     }
 
     await this.sign(file)

diff --git a/packages/builder-util/package.json b/packages/builder-util/package.json
@@ -11,7 +11,7 @@
     "out"
   ],
   "dependencies": {
-    "app-builder-bin": "3.1.6",
+    "app-builder-bin": "3.2.0",
     "temp-file": "^3.3.3",
     "fs-extra": "^8.1.0",
     "is-ci": "^2.0.0",

diff --git a/yarn.lock b/yarn.lock
@@ -1390,10 +1390,10 @@ anymatch@^2.0.0:
     micromatch "^3.1.4"
     normalize-path "^2.1.1"
 
-app-builder-bin@3.1.6:
-  version "3.1.6"
-  resolved "https://registry.yarnpkg.com/app-builder-bin/-/app-builder-bin-3.1.6.tgz#1d35ca0a81dfba15181481fbe8adf68954fedfb9"
-  integrity sha512-jq07wuzB3WXJ7kDtMS7ANQLEH/ZPKtVS5Vtg8xjM2+vc2wdN2qCApvkBRLKuCjaQhVBdN4ZkEVrXzztavuuj4Q==
+app-builder-bin@3.2.0:
+  version "3.2.0"
+  resolved "https://registry.yarnpkg.com/app-builder-bin/-/app-builder-bin-3.2.0.tgz#3ba41721fa38375a4c0ed8f63325dc33f46c20ed"
+  integrity sha512-KmT/k5sKYKixeTUp/chXJ608ddV7M6tsC31BskJ9WWMund+NU+2J5EYTnfysnP+oy6qRtClgPlRgRVFnJOYgzg==
 
 aproba@^1.0.3:
   version "1.2.0"