ci: Bump CI versions #1082
ci: Bump CI versions #1082
Conversation
|
|
Size Change: 0 B Total Size: 25.6 kB ℹ️ View Unchanged
|
| branches-ignore: | ||
| - trying.tmp | ||
| - staging.tmp | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Limiting to master else a PR gets a CI run from both push and & pull_request triggers
|
|
||
| - name: compressed-size-action | ||
| uses: preactjs/compressed-size-action@v2 | ||
| with: | ||
| pattern: 'test/fixtures/**/dist/!(*.map)' | ||
| build-script: 'test' | ||
| repo-token: '${{ secrets.GITHUB_TOKEN }}' |
There was a problem hiding this comment.
I don't know that this is particularly useful, any size difference will be accounted for in the tests already.
| @@ -43,7 +42,7 @@ describe('fixtures', () => { | |||
|
|
|||
| await sleep(1); | |||
|
|
|||
| const output = await buildDirectory(fixtureDir); | |||
There was a problem hiding this comment.
Unfortunately we need to drop this aspect of the suite. gzip & brotli sizes aren't guaranteed to be stable, not through Node versions or on different systems. As such, I was seeing tests pass locally just fine that would then be 1-2b off on the CI.
Besides, all that this aspect was testing was that the gzip & brotli size estimates were stable, which isn't particularly important. If the expected output is stable, it doesn't really matter to us what the gzip/brotli size ends up being.
|
Will then need the required CIs to be updated |
No description provided.