Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better output when building fails on CLI #120

Merged
merged 2 commits into from
Apr 22, 2018

Conversation

jesstelford
Copy link
Contributor

@jesstelford jesstelford commented Apr 17, 2018

Replaces the not-so-useful [object Object] error output

screen shot 2018-04-17 at 2 03 08 pm

❯ yarn dev
yarn run v1.6.0
$ microbundle watch
Watching source, compiling to dist:
[object Object]
✨  Done in 1.85s.

... with the actual error string when available:

screen shot 2018-04-17 at 2 01 32 pm

❯ yarn dev
yarn run v1.6.0
$ microbundle watch
Watching source, compiling to dist:
SyntaxError: Unexpected token (1:7) /Users/jess/dev/cete/landing-page/components/src/index.js (nodent)
export FukolGrid, { FukolItem } from './fukol-grid';
-------^
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

The yarn dev command maps to: microbundle watch

Copy link
Collaborator

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ForsakenHarmony ForsakenHarmony merged commit b2e675c into developit:master Apr 22, 2018
@jesstelford
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants