Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when using cwd and package.source #176

Merged
merged 5 commits into from
Jul 29, 2018
Merged

Fix issue when using cwd and package.source #176

merged 5 commits into from
Jul 29, 2018

Conversation

gribnoysup
Copy link
Contributor

@gribnoysup gribnoysup commented Jul 28, 2018 •
edited
Loading

I added a few tests to cover some use cases of CWD. Initial commit contains a snapshot fixtures custom-source-with-cwd 1 that illustrates what the issue is. Fixed snapshot is committed separately so it is easy to check what was fixed

Fixes #177

@gribnoysup gribnoysup mentioned this pull request Jul 28, 2018
Closed
@gribnoysup
Revert jest env change
005651d 
Moved to separate PR: developit#179
@gribnoysup
Copy link
Contributor Author

gribnoysup commented Jul 29, 2018 •
edited
Loading

Reverted the env change, moved it to another PR so those two separate issues are not tied together in one PR. Expect 005651d to fail tests because of that. Should be fixed after #179 is merged and I can put it here

EDIT: Done 🎉 Tests are passing again

ForsakenHarmony
ForsakenHarmony approved these changes Jul 29, 2018
View reviewed changes
Copy link
Collaborator

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForsakenHarmony ForsakenHarmony merged commit 40a7d28 into developit:master Jul 29, 2018
@gribnoysup gribnoysup deleted the fix/cwd-with-custom-source branch July 29, 2018 20:28
@gribnoysup
Copy link
Contributor Author

🎉

@chopfitzroy chopfitzroy mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using cwd option + package.source doesn't produce build
2 participants
@gribnoysup @ForsakenHarmony