Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont set aliases as externals #671

Merged
merged 1 commit into from
Jun 29, 2020
Merged

fix: dont set aliases as externals #671

merged 1 commit into from
Jun 29, 2020

Conversation

katywings
Copy link
Collaborator

A module cannot be an alias and a external at the same time - rollup just ignores those aliases and keeps them as is.

IS: As example: if a module X is declared as external, the alias X=Y will not work, the bundle will just keep use X.

SHOULD: The alias X=Y should work even if X is declared as external.

@katywings katywings requested a review from developit June 27, 2020 14:35
marvinhagemeister
marvinhagemeister approved these changes Jun 29, 2020
View reviewed changes
Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Thank you so much for your PR 🙌 🥇

@marvinhagemeister marvinhagemeister merged commit 5f1a6a9 into master Jun 29, 2020
@marvinhagemeister marvinhagemeister deleted the fix-external-aliases branch June 29, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katywings @marvinhagemeister