feat: Expands generateTypes flag to support TS entries #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2677748 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
commented
Jul 15, 2021
developit
reviewed
Jul 15, 2021
| @@ -2728,9 +2728,10 @@ ts-custom-declaration | |||
| index.js.map | |||
| index.umd.js | |||
| index.umd.js.map | |||
| node_modules | |||
There was a problem hiding this comment.
to fix CI
Suggested change
| node_modules |
There was a problem hiding this comment.
Clicked "Commit suggestion" too fast there. What was not working w/ the CI? Seemed to be passing w/out any issues?
When rpt2 is used, it creates some cache files in node_modules. As this test now uses a TS entry point, rpt2 will be used.
developit
approved these changes
Jul 15, 2021
rschristian
force-pushed
the
feat/generateTypes-ts
branch
from
d707d35 to
2677748
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature, expands the
--generateTypesflag to also support projects with TS entry points.Did you add tests for your changes?
Modified an existing test
Summary
Closes #863
The problem with the existing
--generateTypesbehavior is that it is only relevant when used with JS entry points.emitDeclarationis derived fromoptions.generateTypesand is only used in the following spot:microbundle/src/index.js
Line 510 in b1a6374
Which means that when
useTypescriptis truthy, that option holds no power whatsoever.useTypescriptwould be truthy on any project that had TS entry points:microbundle/src/index.js
Line 387 in b1a6374
To allow projects with TS entry points to disable types from being output, we now simply disable TS's
declarationcompiler option ifoptions.generateTypesis set to false.Does this PR introduce a breaking change?
No