Fix ref links in titles #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your commitment to size and simplicity is inspiring 😊 |
developit
reviewed
Mar 16, 2017
src/index.js
Outdated
| @@ -20,13 +20,14 @@ function encodeAttr(str) { | |||
| return (str+'').replace(/"/g, '"').replace(/</g, '<').replace(/>/g, '>'); | |||
| } | |||
|
|
|||
| let links = {}; | |||
There was a problem hiding this comment.
I think one issue with the global version is that it won't get cleaned after each outer parse() call. So links declared in one document would be available as references in another.
Are you able to push the alternate contextual version?
|
Not too bad, just a 6 byte increase. Looks good! |
developit
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
Tested both discussed solutions and "global" solution is another one byte smaller, so I went with it 😄