Adapt to Webpack 5 #114
Merged
Adapt to Webpack 5 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrick95
force-pushed
the
kenrick/webpack-5
branch
3 times, most recently
from
7fde4cc to
d439b8a
Compare
kenrick95
force-pushed
the
kenrick/webpack-5
branch
from
d439b8a to
3f93c86
Compare
kenrick95
force-pushed
the
kenrick/webpack-5
branch
from
5dafd09 to
3f93c86
Compare
|
Is this project dead? This Pull Request would be a great addition if this project is intended to be alive :) |
|
It must be because webpack 5 supports this feature. |
|
My apologies, I use Webpack so rarely these days and the API has changed so much that it's been difficult to keep up with merging things. This fix was released as 2.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to support Webpack 5
Fixes #77
I'm aware of #101 but when I use it on my application, it produces some runtime error that I couldn't understand
Note that this still emits a deprecating warning ("Compilation.cache was removed in favor of Compilation.getCache()") due to usage of
compilation.cache, but I'm not too sure how to useCompilation.getCachesince it is lacking documentation (webpack/webpack.js.org#3843)P.S. The tests aren't migrated to webpack 5 yet since karmatic haven't had support for it yet (karma-webpack has it but still in alpha stage)