-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update argument list of download_tile_tms #157
Conversation
Thanks @PallawiSinghal, I think I introduced this bug with the new authentication here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @drewbo, want to double check and merge?
Actually, I think we should solve this by adding
@PallawiSinghal, let me know if you are able to handle this. Otherwise I can. Best way is probably just to open a new PR if you don't know how to revert this commit within this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️
Thank you for your reply. I will do it as soon as possible , by EOD.
Thanks and regards,
Pallawi
…On Tue, 10 Dec, 2019, 5:30 AM Mark Wronkiewicz, ***@***.***> wrote:
Thanks @PallawiSinghal <https://github.com/PallawiSinghal>, I think I
introduced this bug with the new authentication here
<b5c865a#diff-f4145ef8eb8b8faa4e459bb126e8923d>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#157?email_source=notifications&email_token=AD54FIYWGDX2ITMVUNZRD6LQX3LYDA5CNFSM4JQ6QTK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGLEG6I#issuecomment-563495801>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD54FI73TJGEFK3422G7ZBDQX3LYDANCNFSM4JQ6QTKQ>
.
|
Made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but pylint is complaining about a trailing whitespace here. I added the suggested change in the code.
Other than that, LGTM if the checks pass
Co-Authored-By: Mark Wronkiewicz <wronk@developmentseed.org>
Much thanks @PallawiSinghal! Tests are still not passing, but I'm going to fix those right now. CircleCI checks aren't automatically being made visible (per #160), which is means nobody is getting the automatic feedback on their PRs |
As get_image_function in utils.py returns either of get_tile_tif or get_tile_wms or download_tile_tms. All three functions should have the same argument signature.
Fixes issue #156