-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quadkey Support #56
Merged
vincentsarago
merged 14 commits into
developmentseed:master
from
adrian-knauer:quadkey-support
Aug 20, 2021
Merged
Quadkey Support #56
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1d11d04
added NoQuadkeySupport error
1164d44
added check for quadkey support
7f3f355
added test for quadkey check
3bd0338
removed pycharm files
79c443b
really removed pycharm files
a794873
added quadkey and quadkey_to_tile
ac4d33c
added tests for quadkey functions
6d82e35
added test for power of two check
9204a77
made quadkey support an instance attribute
e1865b6
added tests for failing quadkey methods
ecb96f6
makes is_quadkey a pydantic PrivateAttr
9f4e1c0
Merge branch 'master' of https://github.com/developmentseed/morecanti…
vincentsarago bf75728
update changelog
vincentsarago 6841477
fix types
vincentsarago File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -127,3 +127,6 @@ dmypy.json | |
|
||
# Pyre type checker | ||
.pyre/ | ||
|
||
# PyCharm: | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should use
PrivateAttr
https://pydantic-docs.helpmanual.io/usage/models/#private-model-attributes for this.is_quadtree
is not something defined in the TMS spec so I think it would be better if we make it somehowprivate
cc @adrian-knauer @geospatial-jeffFYI: I didn't know about PrivateAttr until today, so I guess this is new to Pydantic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a lot of sense to me! I wasn't aware of
PrivateAttr
as well.