Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: migrate bootstrap5, remove unused css, fix indent, reuse bs classes #1048

Merged
merged 2 commits into from
Dec 19, 2024
Merged

cleanup: migrate bootstrap5, remove unused css, fix indent, reuse bs classes #1048

merged 2 commits into from
Dec 19, 2024

Conversation

pratapvardhan
Copy link
Contributor

This PR migrates application/templates/index.html from bootstrap 4 to bootstrap 5, keeps the visual consistent as before.

  • Removes jquery dependency
  • Remove unused css
  • Reuse bootstrap classes instead of inline-styles.
  • Remove stray end tag
  • Fix html indentation
    cc @vincentsarago
image

@vincentsarago
Copy link
Member

thanks @pratapvardhan

could you please add a note in https://github.com/developmentseed/titiler/blob/main/CHANGES.md#unreleased

@pratapvardhan pratapvardhan force-pushed the bs5 branch 2 times, most recently from 4d8063d to f124a02 Compare December 13, 2024 13:00
@vincentsarago vincentsarago merged commit ae48c2b into developmentseed:main Dec 19, 2024
10 checks passed
@pratapvardhan pratapvardhan deleted the bs5 branch December 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratapvardhan @vincentsarago