use simplejson to allow NaN/inf/-inf in JSON response #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Sep 22, 2021
| ensure_ascii=False, | ||
| allow_nan=False, | ||
| indent=None, | ||
| ignore_nan=True, |
|
Note: in the last commit I choose to use the custom JSONResponse directly in the tiler factories directly to kinda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #373 and fastapi/fastapi#3417
By default FastAPI/starlette will raise an error when we try to JSON encode
float('nan')or+/-float('inf').Recently in rio-tiler we added
nodata_valueinrio_tiler.models.Infowhich can sometimes be set to Nan/inf/-inf. But because of FastAPI/starlette defaults, titiler was failing to return response for /info and /metadata.This PR adds a custom
JSONResponseusing the greatsimplejson(which will translate NaN/inf/-inf values to null).Another solution would have been to change rio-tiler behaviour to stringify nodata value but in my opinion this is an application issues not rio-tiler's