Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the default pixel_selection method to be overidden #495

Merged

Conversation

samn
Copy link
Contributor

@samn samn commented Jul 12, 2022

in the MosaicTilerFactory.

For #492

The default PixelSelectionParams function doesn't change the existing
behavior (it uses PixelSelectionMethod.first if no pixel_selection
query param is provided), but a custom function can be used to change
the default behavior.

…c factory

For developmentseed#492

The default `PixelSelectionParams` function doesn't change the existing
behavior (it uses `PixelSelectionMethod.first` if no `pixel_selection`
query param is provided), but a custom function can be used to change
the default behavior.
@@ -113,7 +114,6 @@ def test_MosaicTilerFactory():
"/mosaic/tiles/7/37/45.npy", params={"url": mosaic_file, "buffer": 10}
)
assert response.status_code == 200
assert response.status_code == 200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 🙏

@vincentsarago vincentsarago self-requested a review July 14, 2022 10:39
@vincentsarago
Copy link
Member

🙏 @samn
I'll update the changelog later

@vincentsarago vincentsarago merged commit 549ad09 into developmentseed:master Jul 14, 2022
@samn
Copy link
Contributor Author

samn commented Jul 14, 2022

Thanks @vincentsarago!

@samn samn deleted the pixel-selection-method-dependency branch July 14, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants