Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a default rescale parameter to be set via a dependency #619

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

samn
Copy link
Contributor

@samn samn commented Mar 29, 2023

What I am changing

  • Add a rescale_dependency field to BaseTilerFactory & MosaicTilerFactory (defaulting to the existing RescalingParams) so users can override the logic for supplying the rescale value. This lets us define a default rescale value from a separate config without needing to include it in the query params for every request.

How I did it

  • Added a dependency to get the rescale value, rather than using a Query directly that can't be overridden.

How you can test it

  • Via the integration tests, or by using the rescale_dependency in an existing application.

@vincentsarago
Copy link
Member

🙏 nice addition @samn

would you be able to add something in the changelog (under a ##Next item) 🙏

This lets us define a default rescale value from a separate config
without needing to include it in the query params for every request.
@samn
Copy link
Contributor Author

samn commented Mar 29, 2023

Thanks @vincentsarago! Just pushed an update to CHANGES.md

@vincentsarago vincentsarago merged commit 738be8a into developmentseed:main Mar 30, 2023
@vincentsarago
Copy link
Member

thank you @samn 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants