Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify band loading #688

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Simplify band loading #688

merged 4 commits into from
Aug 24, 2023

Conversation

tayden
Copy link
Contributor

@tayden tayden commented Aug 21, 2023

What I am changing

  • Simplify and improve default band selection in RGB viewer for both COG and STAC images

How I did it

  • Removed the special band selection logic that applied to the blue band but not the others.
  • Simplified the loading logic so the first three image bands are loaded into the R+G+B channels, respectively, in the viewer.
  • Tested by running the app and manually checking things worked as expected

How you can test it

  • Run the server, load a COG or STAC item

Related Issues

@vincentsarago vincentsarago merged commit e3c6b25 into developmentseed:main Aug 24, 2023
5 of 6 checks passed
@vincentsarago
Copy link
Member

🙏 thanks @tayden

@vincentsarago vincentsarago mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tayden @vincentsarago