-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup ORT for Text and Images #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results153 tests 153 ✅ 2m 39s ⏱️ Results for commit 4f7d123. ♻️ This comment has been updated with latest results. |
Benchmark Results
|
deven96
reviewed
Nov 15, 2024
ahnlich/types/src/ai/preprocess.rs
Outdated
@@ -16,6 +17,7 @@ pub enum StringAction { | |||
pub enum ImageAction { | |||
ResizeImage, | |||
ErrorIfDimensionsMismatch, | |||
ModelPreprocessing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to using ModelProcessing and SkipProcessing
deven96
reviewed
Nov 15, 2024
deven96
reviewed
Nov 16, 2024
deven96
reviewed
Nov 16, 2024
HAKSOAT
force-pushed
the
feat/clipvittext
branch
from
November 26, 2024 10:38
de724a6
to
7f58064
Compare
HAKSOAT
force-pushed
the
feat/clipvittext
branch
from
November 26, 2024 10:53
7f58064
to
66b968b
Compare
deven96
force-pushed
the
feat/clipvittext
branch
from
November 26, 2024 20:34
0b9d9d2
to
9f52737
Compare
deven96
force-pushed
the
feat/clipvittext
branch
from
November 26, 2024 20:46
a555038
to
bf516b0
Compare
deven96
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
This pull requests made the following changes:
On removing dependence on FastEmbed
This is because ORT was used in the implementation for ClipViT, meaning other models could as well just use ORT. The reason for using ORT is because FastEmbed takes away control on how preprocessing works from us, taking raw texts and file names as inputs. Fastembed uses ORT under the hood and a lot of their utility methods are private, so can't be called directly.