-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: EOL problems running CMake tests on Windows #63
fix: EOL problems running CMake tests on Windows #63
Conversation
UpdateOn my branch, I was able to port MSYS2 CI to github. Github is much faster, because jobs run in parallel. |
UpdateIn the current state, which I consider to be ready to merge, I removed the AppVeyor CI integration (deleted Rest assured that CI is now better, which you can check on my branch https://github.com/luau-project/cminpack/tree/fix-cmake-eol-on-tests Github actions (building correctly 49 different tests), including 24 tests with MSYS2 toolchains. Important In order to cancel AppVeyor CI, you have to log in on your account there, and delete the cminpack project on the project settings, otherwise it will continue to fail on each push. |
UpdateMerged master, and restored back AppVeyor file for the checks to pass here. Important However, it is still highly recommended to turn off the AppVeyor CI removing the project on their website, because:
|
LGTM! |
Description
I have improved cminpack build with CMake on Windows. In the actual behavior when building with CMake, in order for the tests to pass, you have to two ways:
git config --global core.autocrlf true
before checking out the source code from github;examples/ref/
In the new behavior, there is no need to perform LF to CRLF conversion anymore.
How
--enable-eol
on file examples/runtest.cmake to discard any EOL differences;--enable-eol
mentioned above, according to https://cmake.org/cmake/help/latest/manual/cmake.1.html, CMake needs to be on version 3.14 or newer. So, I bumped the minimum CMake version to 3.14 on file CMakeLists.txt.Tests
To verify that my proposed changes were correct, I discarded the entries
git config --global core.autocrlf true
in the builds at CI services, which can be found at .github/workflows/windows-visual-studio-cminpack-install.yaml and appveyor.yml.Bonus
I simplified the build on AppVeyor CI appveyor.yml.