Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated Node.js 12 actions in the Registry-Support repo #1226

Closed
kim-tsao opened this issue Aug 21, 2023 · 2 comments · Fixed by devfile/registry-support#181
Closed

Update deprecated Node.js 12 actions in the Registry-Support repo #1226

kim-tsao opened this issue Aug 21, 2023 · 2 comments · Fixed by devfile/registry-support#181
Assignees
@thepetk
Labels
area/registry Devfile registry for stacks and infrastructure kind/user-story User story for new enhancement

Comments

@kim-tsao
Copy link
Contributor

/kind user-story

Which area this user story is related to?

/area registry

User Story

As a devfile developer I want to my github actions updated to the latest, supported Node.js v16 so that my CI workflow will not be disrupted

Acceptance Criteria

Scan the repo actions to determine if the latest runs have Node.js deprecation warnings. E.g. https://github.com/devfile/registry-support/actions/runs/5831903136
Fix the actions by following this blog: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Ensure we are pinning the updates to the commit hash: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
@openshift-ci openshift-ci bot added kind/user-story User story for new enhancement area/registry Devfile registry for stacks and infrastructure labels Aug 21, 2023
@kim-tsao kim-tsao mentioned this issue Aug 21, 2023
Closed
6 tasks
@thepetk thepetk self-assigned this Aug 22, 2023
@thepetk
Copy link
Contributor

thepetk commented Aug 23, 2023

Started working on the issue :)

@thepetk thepetk mentioned this issue Aug 23, 2023
Merged
3 tasks
@thepetk
Copy link
Contributor

thepetk commented Aug 23, 2023

Created a PR in order to update the deprecated actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thepetk thepetk

Labels
area/registry Devfile registry for stacks and infrastructure kind/user-story User story for new enhancement
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update github actions to use nodejs16 thepetk/devfile-registry-support
2 participants
@thepetk @kim-tsao