-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github actions to use nodejs16 #181
Conversation
@thepetk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage 35.93% 35.93%
=======================================
Files 7 7
Lines 1347 1347
=======================================
Hits 484 484
Misses 816 816
Partials 47 47 ☔ View full report in Codecov by Sentry. |
* Update gh actions for nodejs16 Signed-off-by: thepetk <thepetk@gmail.com> * Further updates on gh actions versions Signe-off-by: thepetk <thepetk@gmail.com> Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, thepetk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
/area registry
What does does this PR do / why we need it:
This PR updates specific deprecated github actions in order to ensure that we are not using NodeJS 12 anymore to our GH Actions. More info here
The Github Actions updated are:
actions/checkout@v2
>actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
actions/setup-go@v2
>actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
codecov/codecov-action@v2.1.0
>codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
docker/login-action@v1
>docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc # v2.2.0
Which issue(s) this PR fixes:
Fixes devfile/api#1226
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
The updates have been tested here: https://github.com/thepetk/devfile-registry-support/actions
Note that the actions might failed for the fork but the actions are running correctly