Registry operator should handle environment variable updates

[kim-tsao]

/kind bug

Which area this bug is related to?

/area registry

Bug Summary

Describe the bug:

The DevfileRegistry CRD allows telemetry properties to be specified (registry name, key) and these are mapped to environment variables in the deployment but if a user updates these properties, they do not take into effect (i.e. no live updates). Users would need to re-create the pods in order to see the updates.

To Reproduce:

1. Deploy a DevfileRegistry with Telemetry configuration specified
2. Update the deployment with modified properties (registryName and/or key)
3. The environment variables in the pod are not updated

Expected behavior

Changes should occur on existing pod

Additional context

Looks like it's just the telemetry properties that are affected but I'll review the other ones to make sure we have everything covered.

Any workaround?

Delete the deployment. New pods should have the changes

Suggestion on how to fix the bug

Need to update this method to handle the environment variables: