Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry configs for updating #19

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Mar 2, 2022

Signed-off-by: Kim Tsao ktsao@redhat.com
Fixes PR: devfile/api#784

Manual Testing:

  • Deployed new operator to CRC
  • Deployed Devfile registry and updated/deleted a combination of single and multiple properties

Verified pods were automatically re-created with new ENV variable values

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao requested review from johnmcollier and removed request for johnmcollier March 7, 2022 22:09
Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@openshift-ci openshift-ci bot removed the lgtm label Mar 9, 2022
@openshift-ci openshift-ci bot added the lgtm label Mar 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit 30870a5 into devfile:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants