Add dependentProjects field to devfile/DevWorkspace #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangcao77
requested changes
Oct 17, 2023
| @@ -42,6 +42,9 @@ func ValidateAndReplaceGlobalVariable(workspaceTemplateSpec *v1alpha2.DevWorkspa | |||
|
|
|||
| // Validate the starter projects and replace for global variable | |||
| variableWarning.StarterProjects = ValidateAndReplaceForStarterProjects(workspaceTemplateSpec.Variables, workspaceTemplateSpec.StarterProjects) | |||
|
|
|||
| // Validate the starter projects and replace for global variable | |||
| variableWarning.StarterProjects = ValidateAndReplaceForProjects(workspaceTemplateSpec.Variables, workspaceTemplateSpec.DependentProjects) | |||
There was a problem hiding this comment.
should this be dependentProjects instead?
There was a problem hiding this comment.
Woops! Yes, good catch. I've updated the PR (and the relevant test case to include dependentProjects)
Add field 'dependentProjects' to the devfile API. Dependent projects are additional projects that are related to the 'main' project in a Devfile, allowing a devfile to specify e.g. dependencies or related projects that are useful in development. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
dependentProjects
branch
from
5d26e51
to
47c238f
Compare
yangcao77
approved these changes
Oct 19, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds field
dependentProjectsto the devfile API. For discussion on the purpose of this field, see #1082Which issue(s) does this PR fix
Closes #1082
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer