-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add e2fsprogs library for support IntelliJ IDEA 2021 #25
Conversation
TEMP_DIR="$(mktemp -d)" | ||
cd "${TEMP_DIR}" | ||
E2FSPROGS_VERSION="1.46.5" | ||
E2FSPROGS_TGZ="e2fsprogs-${E2FSPROGS_VERSION}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you need this in downstream UDI image, you'll need a 'prefetch and reuse' approach. See https://github.com/redhat-developer/devspaces-images/blob/devspaces-3-rhel-8/devspaces-udi/get-sources.sh#L76-L92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, in downstream UDI this tarball will be prefetched for offline build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe README file needs to be updated to reflect this new lib
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benoitf, vzhukovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Added a notice about installed library to dedicate section in README.md. |
Since
e2fsprogs-static
package has removed from RHEL 8 distribution, it is not possible to install from the repository.See https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/considerations_in_adopting_rhel_8/index#removed-packages_changes-to-packages
There is a proposal to include latest released version of
e2fsprogs
.e2p.so
is used by the IntelliJ IDEA FileSystemUtil.java#L763-L769.Part of eclipse-che/che#21007
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com