DevTools Week: Create devfile for landing page and registry viewer #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e8c7349. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
michael-valdron
force-pushed
the
viewer-devfile
branch
2 times, most recently
from
d3a71e4
to
10b66c1
Compare
2 tasks
michael-valdron
force-pushed
the
viewer-devfile
branch
from
10b66c1
to
86de855
Compare
michael-valdron
force-pushed
the
viewer-devfile
branch
4 times, most recently
from
323301d
to
abb4f1b
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
viewer-devfile
branch
from
abb4f1b
to
dae78ab
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
viewer-devfile
branch
from
dae78ab
to
e8c7349
Compare
michael-valdron
changed the title
michael-valdron
changed the title
mike-hoang
reviewed
Apr 17, 2023
mike-hoang
approved these changes
Apr 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, mike-hoang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it
Adds a devfile for developing the landing page, doc pages, and the registry viewer.
Use
projectto select a development deployment of thelanding-pageorregistry-viewer.Which issue(s) does this PR fix
Fixes #?
part of devfile/api#1069
PR acceptance criteria
Update the sidebar if there is a new file added or an existing filename is changed
How to test changes / Special notes to the reviewer