Skip to content

Commit

Permalink
Make common PVC sync error messages consistent with per-workspace
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
  • Loading branch information
AObuchow committed May 31, 2023
1 parent da20734 commit e6677dc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/provision/storage/shared.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ func syncCommonPVC(namespace string, config *v1alpha1.OperatorConfiguration, clu
break
case *sync.NotInSyncError:
return nil, &dwerrors.RetryError{
Message: "Updated common PVC on cluster",
Message: fmt.Sprintf("Updated %s PVC on cluster", pvc.Name),
}
case *sync.UnrecoverableSyncError:
return nil, &dwerrors.FailError{
Message: "Failed to sync PVC to cluster",
Message: fmt.Sprintf("Failed to sync %s PVC to cluster", pvc.Name),
Err: t.Cause,
}
default:
Expand All @@ -122,7 +122,7 @@ func syncCommonPVC(namespace string, config *v1alpha1.OperatorConfiguration, clu

currPVC, ok := currObject.(*corev1.PersistentVolumeClaim)
if !ok {
return nil, errors.New("tried to sync PVC to cluster but did not get a PVC back")
return nil, errors.New("tried to sync common PVC to cluster but did not get a PVC back")
}
// TODO: Does not work for WaitFirstConsumer storage type; needs to be improved.
// if currPVC.Status.Phase != corev1.ClaimBound {
Expand Down

0 comments on commit e6677dc

Please sign in to comment.