Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for Webhook deployment configuration #1289

Open
AObuchow opened this issue Jul 15, 2024 · 0 comments
Open

Improve documentation for Webhook deployment configuration #1289

AObuchow opened this issue Jul 15, 2024 · 0 comments
Assignees
@AObuchow

Comments

@AObuchow
Copy link
Collaborator

Description

#1281 added support for configuring the webhook deployment, however two important details were not included in the CRD documentation:

  • Changes to the DWOC's config.webhook fields only take effect after restarting the devworkspace-controller-manager pod
  • The DWOC's config.webhook fields only take effect when they are set in the global DWOC.

These details should be included in the CRD documentation. They should also be additionally mentioned in the additional docs.
@AObuchow AObuchow changed the title Improve documentation for WebHook deployment configuration Improve documentation for Webhook deployment configuration Jul 15, 2024
@AObuchow AObuchow self-assigned this Aug 7, 2024
@AObuchow AObuchow mentioned this issue Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AObuchow AObuchow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AObuchow