Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install devworkspace-webhook-server on a specific node #1308

Closed
huonguyenlt opened this issue Aug 16, 2024 · 1 comment
Closed

Cannot install devworkspace-webhook-server on a specific node #1308

huonguyenlt opened this issue Aug 16, 2024 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@huonguyenlt
Copy link

Description

I deployed devworkspace-operator using this template https://github.com/devfile/devworkspace-operator/blob/v0.29.0/deploy/deployment/kubernetes/combined.yaml.
After the devworkspace-controller-manager is deployed, it will deploy the devworkspace-webhook-server. The problem is I cannot tell the devworkspace-webhook-server to deploy on a specific node. Or maybe there is an option to do that, if there is, please show me. Thanks

@AObuchow
Copy link
Collaborator

Webhook deployment configuration was just added in DevWorkspaceOperator 0.30.0 so you'll need to deploy it with https://github.com/devfile/devworkspace-operator/blob/v0.30.0/deploy/deployment/kubernetes/combined.yaml.

This feature hasn't been document (yet), see #1289.

For your use case, you'll probably want to use the nodeSelector. You can add a label to your desired node, and use a nodeSelector for the webhook server to have the webhook deployed to your desired node. For an example, see the "Verifying nodeSelector" section of this PR.

Here's a quick explanation of the webhook server deployment configuration options:

The devworkspace-webhook-server deployment configuration options are available in the global DevWorkspaceOperatorConfig (DWOC) including: replicas, pod tolerations and nodeSelector.

These configuration options exist in the global DWOC's config.webhook field:

apiVersion: controller.devfile.io/v1alpha1
kind: DevWorkspaceOperatorConfig
metadata:
  name: devworkspace-operator-config
  namespace: $OPERATOR_INSTALL_NAMESPACE
config:  
 routing:  
   clusterHostSuffix: 192.168.49.2.nip.io  
   defaultRoutingClass: basic  
 webhook:  
   nodeSelector:  <string, string>
   tolerations: <[]tolerations>
   replicas: <int32> 

Note: In order for the devworkspace-webhook-server configuration options to take effect:

  • You must place them in the global DWOC, which has the name devworkspace-operator-config and exists in the namespace where the DevWorkspaceOperator is installed. If it does not already exist on the cluster, you must create it.
  • You'll need to terminate the devworkspace-controller-manager pod and restart it so that the devworkspace-webhook-server deployment can be adjusted accordingly.

If you have any further questions on configuring the webhook deployment, just ask :) Otherwise, feel free to close this issue.

@AObuchow AObuchow self-assigned this Aug 16, 2024
@AObuchow AObuchow added the question Further information is requested label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants