Automount configmaps/secrets into devworkspaces

[tinakurian]

What does this PR do?

Automounts configmaps/secrets to all devworkspace if the automount label is present.

What issues does this PR fix or reference?

#384

Is it tested? How?

1. make install

cat << EOF | oc apply -f -
apiVersion: v1
kind: ConfigMap
metadata:
  name: file-configmap
  namespace: devworkspace-controller
  labels:
    controller.devfile.io/mount-to-devworkspace: "true"
#  annotations:
#    controller.devfile.io/mount-as: file # default behavior
type: Opaque
data:
  important-cfg: "test"
EOF

cat << EOF | oc apply -f -
apiVersion: v1
kind: ConfigMap
metadata:
  name: file-configmap-custom-path
  namespace: devworkspace-controller
  labels:
    controller.devfile.io/mount-to-devworkspace: "true"
  annotations:
#    controller.devfile.io/mount-as: file # default behavior
    controller.devfile.io/mount-path: /etc/config/custom-mount-path/here
type: Opaque
data:
  important-cfg: "test"
EOF

cat << EOF | oc apply -f -
apiVersion: v1
kind: Secret
metadata:
  name: env-var-secret
  labels:
    controller.devfile.io/mount-to-devworkspace: "true"
  annotations:
    controller.devfile.io/mount-as: env
stringData:
  secret_username: admin
  secret_password: t0p-Secret
EOF

4. oc apply -f samples/web-terminal-custom-tooling.yaml
5. kubectl exec -it -c tooling -- bash
6. ls /etc/config
7. env | grep secret_

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tinakurian
To complete the pull request process, please assign sleshchenko after the PR has been reviewed.
You can assign the PR to them by writing /assign @sleshchenko in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[amisevsk]

A couple structural comments

[sleshchenko]

In general LGTM, just a few stuff that Che may also need.
But I'm OK with handling it out of the current PR

[amisevsk]

PR in its current state looks good to me -- I'm 👍 to merge as-is and add additional features (mount as env or mount as volume) separately, or add to this PR if that's easier.

[sleshchenko]

LGTM
I'm going to test it tomorrow (please make sure PR description is up to date).
It seems to be a good time that we start documenting devWorkspaces feature, but it's out of the current PR scope.

[amisevsk]

Tested again on OpenShift (yesterday) and both mount-as: env and the default work for me.

I did run into an issue on crc but I think that's a me problem rather than a problem with this code. That issue also reproduced on the main branch, also.

[tinakurian]

Tested again on OpenShift (yesterday) and both mount-as: env and the default work for me.

I did run into an issue on crc but I think that's a me problem rather than a problem with this code. That issue also reproduced on the main branch, also.

Thanks @amisevsk I realized the issue i was seeing happens if i just use make install + make uninstall a few times. But running make docker install restart seems to resolve it. Thanks for testing it for me! Greatly appreciated!

[sleshchenko]

LGTM I left just a few minor comments
Tested and works as expected. I hope you don't mind that I updated testing instructiond

[tinakurian]

LGTM I left just a few minor comments
Tested and works as expected. I hope you don't mind that I updated testing instructiond

Not at all! Thanks for taking the time to update it @sleshchenko!

[tinakurian]

/retest

[sleshchenko]

/test v7-images

[openshift-ci]

@tinakurian: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/v7-devworkspace-happy-path	17a4dd1	link	/test v7-devworkspace-happy-path
ci/prow/v7-images	9b9601d	link	/test v7-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, sleshchenko, tinakurian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amisevsk,sleshchenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment