Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-cluster offline devfile registry installation manual instruction #159

Merged
merged 17 commits into from
Jun 30, 2022

Conversation

michael-valdron
Copy link
Member

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR
registry docs

What does does this PR do / why we need it:

Adds manual instruction for installation of an in-cluster offline devfile registry.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#770

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

🎊 Navigate the preview: https://devfile-docs-159.surge.sh 🎊

@michael-valdron michael-valdron changed the title Added in-cluster offline devfile registry installation manual instruction Add in-cluster offline devfile registry installation manual instruction Jun 8, 2022
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Member Author

blocked by devfile/registry-support#118

Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see doc suggested changes :)

…ry removed.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…edure step.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…of-incluster-offline-devfile-registry.adoc to match page title.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ges:

- IBM SG fix to first paragraph
- "2 stages" changed to "two stages"
- devfile/registry example and link removed from stage 1 summary

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ade.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 23, 2022
…Registry' example removed, example is just treated as generic.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…hanged to 'devfile-index'.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…rojects.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…starter projects.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ded.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Jun 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit f2085ec into devfile:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual instructions on installation in-cluster devfile registry offline
3 participants