Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse parent via kube crd reference #78

Merged
merged 11 commits into from
Apr 13, 2021

Conversation

yangcao77
Copy link
Collaborator

@yangcao77 yangcao77 commented Apr 6, 2021

What does this PR do?

parse parent via kube crd reference

What issues does this PR fix or reference?

Fixes devfile/api#355

Is your PR tested? Consider putting some instruction how to test your changes

added unit tests

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
…Tool struct to save instead

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part 1 of the review

pkg/devfile/parser/data/versions.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse.go Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
pkg/devfile/parser/resolutionContext.go Outdated Show resolved Hide resolved
pkg/devfile/parser/resolutionContext.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
Signed-off-by: Stephanie <yangcao@redhat.com>
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
pkg/devfile/parser/data/versions.go Outdated Show resolved Hide resolved
pkg/devfile/parser/resolutionContext.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
pkg/devfile/parser/parse_test.go Outdated Show resolved Hide resolved
pkg/testingutil/k8sClient.go Show resolved Hide resolved
pkg/devfile/parser/parse.go Outdated Show resolved Hide resolved
Signed-off-by: Stephanie <yangcao@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit ffe3a0a into devfile:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull and parse parent devfile from Kubernetes CRD in library
3 participants