Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry option #14

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Conversation

GeekArthur
Copy link
Contributor

@GeekArthur GeekArthur commented Aug 3, 2021

This PR adds the telemetry option to consumer so that consumer can opt in/out the registry telemetry when using operator to deploy the registry.

Issue: devfile/api#281

Signed-off-by: Jingfu Wang jingfwan@redhat.com

Signed-off-by: Jingfu Wang <jingfwan@redhat.com>
@GeekArthur GeekArthur self-assigned this Aug 3, 2021
@GeekArthur GeekArthur changed the title Add telemetry to option Add telemetry option Aug 3, 2021
pkg/registry/deployment.go Outdated Show resolved Hide resolved
pkg/registry/deployment.go Outdated Show resolved Hide resolved
api/v1alpha1/devfileregistry_types.go Outdated Show resolved Hide resolved
Signed-off-by: Jingfu Wang <jingfwan@redhat.com>
Signed-off-by: Jingfu Wang <jingfwan@redhat.com>
@GeekArthur
Copy link
Contributor Author

@johnmcollier Comments addressed, please review again.

@openshift-ci openshift-ci bot added the lgtm label Aug 5, 2021
Signed-off-by: Jingfu Wang <jingfwan@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Aug 6, 2021
@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GeekArthur, johnmcollier

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GeekArthur GeekArthur merged commit 17fe9d4 into devfile:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants