Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the operator to support the registry viewer #15

Merged
merged 7 commits into from
Aug 19, 2021

Conversation

johnmcollier
Copy link
Member

Updates the registry operator to support the devfile registry viewer:

  • Adds the viewer config json file to the registry config map
  • Adds a startupProbe

Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
@johnmcollier johnmcollier changed the title WIP: Update the operator to support the registry viewer Update the operator to support the registry viewer Aug 5, 2021
Signed-off-by: John Collier <jcollier@redhat.com>
Copy link
Contributor

@GeekArthur GeekArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, please rebase and retest the PR.

…ortRegViewer

Signed-off-by: John Collier <jcollier@redhat.com>
@johnmcollier
Copy link
Member Author

@GeekArthur Rebased.

@johnmcollier
Copy link
Member Author

@GeekArthur Note though that tests will still fail until devfile/registry-support#73 is merged.

@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GeekArthur, johnmcollier

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2021

New changes are detected. LGTM label has been removed.

@johnmcollier
Copy link
Member Author

/retest

1 similar comment
@johnmcollier
Copy link
Member Author

/retest

Signed-off-by: John Collier <jcollier@redhat.com>
@johnmcollier johnmcollier merged commit ac8e7c2 into devfile:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants