Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Kube API for Ingress & CRDs #16

Merged
merged 9 commits into from
Oct 12, 2021
Merged

Updates Kube API for Ingress & CRDs #16

merged 9 commits into from
Oct 12, 2021

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Oct 5, 2021

johnmcollier and others added 5 commits October 1, 2021 17:23
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal
Copy link
Member Author

/test v4.5-registry-operator-integration-test

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@johnmcollier
Copy link
Member

Seems like CI flakiness

/retest

@johnmcollier
Copy link
Member

/retest

Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes all around. LGTM.

Thanks for getting this done @maysunfaisal

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, maysunfaisal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier
Copy link
Member

/retest

1 similar comment
@johnmcollier
Copy link
Member

/retest

@josephca
Copy link

josephca commented Oct 7, 2021

/test all

@johnmcollier
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Oct 12, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2021

@maysunfaisal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.5-registry-operator-integration-test 85b3382 link true /test v4.5-registry-operator-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johnmcollier
Copy link
Member

/retest

Signed-off-by: John Collier <jcollier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants