-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Kube API for Ingress & CRDs #16
Conversation
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
/test v4.5-registry-operator-integration-test |
19c9c9a
to
738ed37
Compare
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
738ed37
to
85b3382
Compare
Seems like CI flakiness /retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes all around. LGTM.
Thanks for getting this done @maysunfaisal
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johnmcollier, maysunfaisal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/test all |
/retest |
Signed-off-by: John Collier <jcollier@redhat.com>
New changes are detected. LGTM label has been removed. |
@maysunfaisal: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
This PR updates Kube APIs for Ingress and CRDs as per https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/
Fixes devfile/api#633
devfile/api#636
Helm PR devfile/registry-support#88