Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #21

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Create CONTRIBUTING.md #21

merged 5 commits into from
Jun 28, 2022

Conversation

johnmcollier
Copy link
Member

Signed-off-by: John Collier jcollier@redhat.com

Signed-off-by: John Collier <jcollier@redhat.com>
Copy link
Contributor

@mike-hoang mike-hoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor nits -- I think the actual content looks good

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, mike-hoang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Michael Hoang <35011707+mike-hoang@users.noreply.github.com>
@openshift-ci openshift-ci bot removed the lgtm label Jun 22, 2022
johnmcollier and others added 3 commits June 22, 2022 14:53
Co-authored-by: Michael Hoang <35011707+mike-hoang@users.noreply.github.com>
Co-authored-by: Michael Hoang <35011707+mike-hoang@users.noreply.github.com>
@johnmcollier
Copy link
Member Author

@mike-hoang Review comments addressed.

@mike-hoang
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 22, 2022
@johnmcollier
Copy link
Member Author

/retest

@johnmcollier johnmcollier merged commit 2e32d81 into main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants