New CR types, controllers and webhooks

[kim-tsao]

Fixes issue : devfile/api#499

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kim-tsao]

/retest

[johnmcollier]

Two small-ish suggestions, otherwise I have no concerns. Some good changes in here 👍

[johnmcollier]

Might be useful to show how to get the resource when not running within a controller.

E.g. like what we do in the tests for getting instances of the devfileregistries CR:

registry-operator/tests/integration/pkg/client/registry.go

Lines 27 to 48 in 2e32d81

	func (w *K8sClient) GetRegistryInstance(name string) (*registryv1alpha1.DevfileRegistry, error) {
	data, err := w.kubeClient.RESTClient().
	Get().
	AbsPath("/apis/registry.devfile.io/v1alpha1").
	Namespace(config.Namespace).
	Resource("devfileregistries").
	Name(name).
	DoRaw(context.TODO())
	if err != nil {
	return nil, err
	}
	// Unmarshall the struct
	registry := &registryv1alpha1.DevfileRegistry{}
	err = yaml.Unmarshal(data, registry)
	if err != nil {
	return nil, err
	}
	return registry, nil
	}

[kim-tsao]

@johnmcollier Does it make sense to keep the existing example too?

[johnmcollier]

Can’t hurt?

[kim-tsao]

Updated README with new example